-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Element
and Composite
components
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwcj-engine/src/main/java/org/dwcj/component/element/ElementComposite.java
Show resolved
Hide resolved
dwcj-engine/src/main/java/org/dwcj/component/element/ElementComposite.java
Show resolved
Hide resolved
dwcj-engine/src/test/java/org/dwcj/component/element/ElementCompositeMock.java
Show resolved
Hide resolved
dwcj-engine/src/test/java/org/dwcj/component/event/EventSinkListenerRegistryTest.java
Show resolved
Hide resolved
dwcj-engine/src/test/java/org/dwcj/component/event/EventSinkListenerRegistryTest.java
Show resolved
Hide resolved
dwcj-engine/src/test/java/org/dwcj/component/event/sink/EventSinkMock.java
Show resolved
Hide resolved
dwcj-addons/dwcj-googlecharts/src/test/java/org/dwcj/addons/googlecharts/GoogleChartTest.java
Outdated
Show resolved
Hide resolved
dwcj-addons/dwcj-youtube/src/main/java/org/dwcj/addons/youtube/Youtube.java
Show resolved
Hide resolved
hyyan
requested review from
mhawkinsbasis and
MatthewHawkins
and removed request for
StephanWald and
mhawkinsbasis
December 5, 2023 09:37
dwcj-engine/src/main/java/org/dwcj/component/element/annotation/ElementAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
MatthewHawkins
approved these changes
Dec 5, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
hyyan
requested review from
mhawkinsbasis
and removed request for
mhawkinsbasis
December 5, 2023 14:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #399 , #427, #436
The PR removes the outdated
WebComponent
class and introduces theElementComposite
class, designed for creating new components based on a native, custom-element, or a web component.ElementComposite
extends the newly introducedComposite
class. This class acts as a blueprint for composite components, high-level constructs aimed at encapsulating and managing specific Component instances. It mandates that any subclass extending it must define the type of Component it will manage, thereby ensuring that a subclass ofComposite
is inherently connected to its corresponding Component.ElementComposite
is linked to the Element class, which represents an HTML Element. It offers methods for setting and retrieving HTML content, manipulating properties, adding event listeners to the element, and executing JavaScript through a fluent async API.The Engine uses these new APIs in: AppLayout, Dialog , Drawer, Youtube and GoogleChart components
Composite Sample
ElementComposite Sample
Element Sample