Use SplFileInfo

[webflo]

No description provided.

[luenemam]

Looks great! Thanks.
Though there is no need to use SplFileInfo for this too work... https://github.com/luenemam/drupal-finder/blob/simplify-locateRoot/src/DrupalFinder.php#L30
I have no idea whats better...

When i went to SplFileInfo i was searching for an Iterator to walk up the FileSystem.

Something like this:

$paths = new WalkupFilesystemToRootIncludingSymlinksIterator($startpath);
foreach (paths as $path => $file_info) {
  if ($this->isValidRoot($path)) {
    return TRUE;
  }
}

Didn't find anything like that.

[luenemam]

The first call to $path->getRealPath() clears all symlinks. see SplFileInfo::getRealPath
So for $follow_symlinks = TRUE we will not finde any more symlinks. No need to check for a link in the loop.

What are the use cases for not following symlinks?

• shared modules

any more?

We should add explicit tests for this use cases.

[luenemam]

The test are good, my idea of the simplification was wrong...

[luenemam]

This works only with a streamwrapper... not a real FS... it get's into a loop at fs-root.