fix(MeetingSdkAdapter): rename controls to match component

webex · Jan 29, 2020 · 48c6051 · 48c6051
1 parent 9e0558d
commit 48c6051
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/scripts/puppeteer.server.js b/scripts/puppeteer.server.js
@@ -3,15 +3,15 @@ import webexSDKAdapter from './start';
 let MEETING_ID = null;
 
 function handleAudio() {
-  webexSDKAdapter.meetingsAdapter.meetingControls.audio.display(MEETING_ID).subscribe((data) => {
+  webexSDKAdapter.meetingsAdapter.meetingControls['mute-audio'].display(MEETING_ID).subscribe((data) => {
     const muteAudio = document.getElementById('mute-audio');
 
     muteAudio.innerHTML = `${data.tooltip} audio`;
   });
 }
 
 function handleVideo() {
-  webexSDKAdapter.meetingsAdapter.meetingControls.video.display(MEETING_ID).subscribe((data) => {
+  webexSDKAdapter.meetingsAdapter.meetingControls['mute-video'].display(MEETING_ID).subscribe((data) => {
     const muteVideo = document.getElementById('mute-video');
 
     muteVideo.innerHTML = data.tooltip;
@@ -83,7 +83,7 @@ document.getElementById('actions').addEventListener('click', async (event) => {
   try {
     switch (event.target.id) {
       case 'mute-audio':
-        await webexSDKAdapter.meetingsAdapter.meetingControls.audio.action(MEETING_ID);
+        await webexSDKAdapter.meetingsAdapter.meetingControls['mute-audio'].action(MEETING_ID);
         break;
       case 'mute-video':
         await webexSDKAdapter.meetingsAdapter.handleLocalVideo(MEETING_ID);

diff --git a/src/MeetingsSDKAdapter.js b/src/MeetingsSDKAdapter.js
@@ -8,8 +8,8 @@ const EVENT_MEDIA_STOPPED = 'media:stopped';
 const EVENT_MEDIA_LOCAL_UPDATE = 'adapter:media:local:update';
 const JOIN_CONTROL = 'join-meeting';
 const EXIT_CONTROL = 'leave-meeting';
-const AUDIO_CONTROL = 'audio';
-const VIDEO_CONTROL = 'video';
+const AUDIO_CONTROL = 'mute-audio';
+const VIDEO_CONTROL = 'mute-video';
 const MEDIA_TYPE_LOCAL = 'local';
 const MEDIA_TYPE_REMOTE_AUDIO = 'remoteAudio';
 const MEDIA_TYPE_REMOTE_VIDEO = 'remoteVideo';
@@ -491,7 +491,7 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter {
     };
     const unmuted = {
       ID: VIDEO_CONTROL,
-      icon: 'camera',
+      icon: 'camera-muted',
       tooltip: 'Stop video',
       state: MeetingControlState.INACTIVE,
       text: null,

diff --git a/src/MeetingsSDKAdapter.test.js b/src/MeetingsSDKAdapter.test.js
@@ -278,7 +278,7 @@ describe('Meetings SDK Adapter', () => {
     test('returns the display data of a meeting control in a proper shape', (done) => {
       meetingSDKAdapter.audioControl(meetingID).subscribe((dataDisplay) => {
         expect(dataDisplay).toMatchObject({
-          ID: 'audio',
+          ID: 'mute-audio',
           icon: 'microphone-muted',
           tooltip: 'Mute',
           state: 'inactive',
@@ -337,7 +337,7 @@ describe('Meetings SDK Adapter', () => {
     test('emits the custom event after muting the audio track', async () => {
       await meetingSDKAdapter.handleLocalAudio(meetingID);
       expect(mockSDKMeeting.emit).toHaveBeenCalledWith('adapter:media:local:update', {
-        control: 'audio',
+        control: 'mute-audio',
         state: false,
       });
     });
@@ -359,7 +359,7 @@ describe('Meetings SDK Adapter', () => {
       meetingSDKAdapter.meetings[meetingID].localAudio = null;
       await meetingSDKAdapter.handleLocalAudio(meetingID);
       expect(mockSDKMeeting.emit).toHaveBeenCalledWith('adapter:media:local:update', {
-        control: 'audio',
+        control: 'mute-audio',
         state: true,
       });
     });
@@ -380,8 +380,8 @@ describe('Meetings SDK Adapter', () => {
     test('returns the display data of a meeting control in a proper shape', (done) => {
       meetingSDKAdapter.videoControl(meetingID).subscribe((dataDisplay) => {
         expect(dataDisplay).toMatchObject({
-          ID: 'video',
-          icon: 'camera',
+          ID: 'mute-video',
+          icon: 'camera-muted',
           tooltip: 'Stop video',
           state: 'inactive',
           text: null,
@@ -439,7 +439,7 @@ describe('Meetings SDK Adapter', () => {
     test('emits the custom event after muting the video track', async () => {
       await meetingSDKAdapter.handleLocalVideo(meetingID);
       expect(mockSDKMeeting.emit).toHaveBeenCalledWith('adapter:media:local:update', {
-        control: 'video',
+        control: 'mute-video',
         state: false,
       });
     });
@@ -461,7 +461,7 @@ describe('Meetings SDK Adapter', () => {
       meetingSDKAdapter.meetings[meetingID].localVideo = null;
       await meetingSDKAdapter.handleLocalVideo(meetingID);
       expect(mockSDKMeeting.emit).toHaveBeenCalledWith('adapter:media:local:update', {
-        control: 'video',
+        control: 'mute-video',
         state: true,
       });
     });