Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve behavior fetching CSS shorthand properties #6163

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Improve behavior fetching CSS shorthand properties #6163

merged 1 commit into from
Nov 27, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch improves the behavior documented in #6161. Instead of just returning an empty result in Firefox it is now behaving the same.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 26, 2020
@christian-bromann christian-bromann requested a review from a team November 26, 2020 08:50
@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Nov 26, 2020
mgrybyk
mgrybyk approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 3950cb1 into master Nov 27, 2020
@christian-bromann christian-bromann deleted the cb-shorthand-properties branch November 27, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrybyk mgrybyk mgrybyk approved these changes

Assignees
No one assigned
Labels
needs-review These Pull Requests require review from project members PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-bromann @mgrybyk