Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allure-reporter: mime type types #6022

Merged
merged 1 commit into from
Oct 22, 2020
Merged

allure-reporter: mime type types #6022

merged 1 commit into from
Oct 22, 2020

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Oct 22, 2020

Proposed changes

  • better handle attachment type in addAttachment
  • fix content type
  • add StepStatus type for endStep

Types of changes

  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@mgrybyk mgrybyk added the PR: Docs 📝 PRs that contain changes to the documentation label Oct 22, 2020
christian-bromann
christian-bromann approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit aa7a567 into master Oct 22, 2020
@christian-bromann christian-bromann deleted the allure-add-attachment-mime-type branch October 22, 2020 16:49
@jaworsmi jaworsmi mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrybyk @christian-bromann