Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriverio: mock respond in request stage #6006

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Oct 19, 2020

Proposed changes

Added
Allow sending a mocked response in the Request stage.
In other words, add an option to not wait for a backend to respond before sending a mocked response.

image

#6004

Changed
abort and abortOnce commands are now aborting a request and not waiting for a response.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

still have to add tests...

Reviewers: @webdriverio/project-committers

@mgrybyk mgrybyk added the PR: New Feature 🚀 PRs that contain new features label Oct 19, 2020
@mgrybyk mgrybyk closed this Oct 19, 2020
@mgrybyk mgrybyk reopened this Oct 19, 2020
@mgrybyk mgrybyk marked this pull request as ready for review October 19, 2020 19:51
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we skip doesn't it mean 'Fetch.continueRequest'

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense. Thanks! 👍

@mgrybyk mgrybyk merged commit 2529189 into master Oct 20, 2020
christian-bromann pushed a commit that referenced this pull request Oct 22, 2020
* webdriverio: mock respond in request stage
@mgrybyk mgrybyk deleted the mock-respond-in-request-stage branch November 2, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants