Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add "Migrating from Chai" section #5549

Merged
merged 4 commits into from
Jun 26, 2020
Merged

docs: Add "Migrating from Chai" section #5549

merged 4 commits into from
Jun 26, 2020

Conversation

caweidmann
Copy link
Contributor

Proposed changes

Adds new "Migrating from Chai" section to "Assertion" page (#5537).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@jsf-clabot
Copy link

jsf-clabot commented Jun 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

christian-bromann
christian-bromann requested changes Jun 26, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, otherwise LGTM

docs/Assertion.md Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
docs/Assertion.md Outdated Show resolved Hide resolved
christian-bromann
christian-bromann approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you so much and congratulations on your first WebdriverIO contribution 🎉 Looking forward for more to come 😉

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jun 26, 2020
@christian-bromann christian-bromann merged commit 704133c into webdriverio:master Jun 26, 2020
@christian-bromann christian-bromann mentioned this pull request Jun 26, 2020
Closed
@caweidmann
Copy link
Contributor Author

Haha, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caweidmann @jsf-clabot @christian-bromann