Script fixes for IE #5279
Merged
Script fixes for IE #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinheitzman
requested changes
Apr 17, 2020
| for (let shadowElement of elemsWithShadowRoot) { | ||
| shadowElementsFromPoint.push(...getOverlappingElements(elem, shadowElement.shadowRoot)) | ||
| for (let i = 0; i < elemsWithShadowRoot.length; ++i) { | ||
| let shadowElement = elemsWithShadowRoot[i] |
There was a problem hiding this comment.
if the idea is to make it all ES5 and thus IE11 compatible then the keywords let and const cannot be used either.
There was a problem hiding this comment.
@erwinheitzman let and const are supported by IE11: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let
christian-bromann
added
needs-review
erwinheitzman
approved these changes
Apr 20, 2020
|
Great news! Is there a release date for this fix? |
|
@j320 this was already released. Please see changelog. |
christian-bromann
added
backported
christian-bromann
added a commit
that referenced
this pull request
May 25, 2020
* fix scripts for IE - closes #5043 * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #5043
Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers