Added browserVersion to startElectron

[hpsjakob]

Hello,

I'm using the wdio-electron-service for programmatically starting electron.
In my case it's not possible to auto detect the electron version, since the UI-Tests are in a separate project.

For that reason I'd like to pass the version as browserVersion to startElectron. Unfortunately that's not possible until now as it's not part of the electron capabilities.

This PR adds the browserVersion to startElectron but keeps it backward compatible. I added it to an interface so that additional parameters can be added in the future.
Please let me know if you like the approach of if you’ve a different idea how to solve this challenge.

Regards,
Jakob

[goosewobbler]

Hi Jakob,

What's the actual issue behind the PR - why exactly do you need browserVersion here? Are you getting an error running the service with your project?

I can see that browserVersion is not being supplied to the capabilities, so the first operand in this line is never going to affect the electronVersion value:

wdio-electron-service/packages/wdio-electron-service/src/launcher.ts

Line 50 in 11f1fcb

const electronVersion = cap.browserVersion || localElectronVersion || '';

Presumably you are using appBinaryPath to specify where your app binary is. In the first instance I suggest we can detect the Electron version from the nearest package.json to that path, in the same way that we check the local Electron version.

e.g.

const electronVersion = appBinaryElectronVersion || localElectronVersion || '';

[hpsjakob]

You're right. I'm setting appBinaryPath. The reason for that is my projet structure:

/package.json <-- electron-build
/e2e-test/package.json <-- wdio tests

I had to choose this project structure as I want to seperate the dependencies (That is required since I use a native lib once in electron and once on the test host).

Would it make sense to then instead pass something like appProjectDir instead of appBinaryDir? Then we could use the existing logic to auto-detect binary path and version.

[goosewobbler]

Work on this is continuing in #858.