Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @electron/packager to dependencies #578

Conversation

Benricheson101
Copy link
Contributor

@Benricheson101 Benricheson101 commented May 20, 2024

Moves @electron/packager from devDependencies to dependencies so it is (recursively) installed by npm ci.

Otherwise this import throws a runtime error:

import { allOfficialArchsForPlatformAndVersion } from '@electron/packager';

@goosewobbler
Copy link
Member

@Benricheson101 Good catch! I was able to reproduce the issue in wdio-electron-service-example. I'm wondering how this got past the E2Es - we need to ensure these issues will be caught before release - will look at this as part of #443.

@goosewobbler goosewobbler merged commit 0f9c005 into webdriverio-community:main May 21, 2024
4 checks passed
@goosewobbler goosewobbler mentioned this pull request May 21, 2024
@goosewobbler goosewobbler mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants