(fix): update scripts & docs for Husky v9 #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosewobbler
changed the title
|
Interesting. I'll make a note to check if we've missed this elsewhere in the orgs. The How to Migrate section of the docs you linked also says we can drop these lines from the hooks too: - #!/usr/bin/env sh
- . "$(dirname -- "$0")/_/husky.sh"
npm test |
seanpoulter
requested review from
seanpoulter
and removed request for
seanpoulter
|
@seanpoulter Good catch - I'm sure I updated this code already but obviously it never got committed. Maybe stashed on a branch somewhere. |
|
closing in favour of #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Husky was updated but
husky installwas deprecated, this PR fixes the scripts to run Husky onprepareand updates the docs accordingly.https://github.com/typicode/husky/releases/tag/v9.0.1