Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass browserInstance through to execute #329

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix: pass browserInstance through to execute #329

merged 9 commits into from
Dec 12, 2023

Conversation

goosewobbler
Copy link
Member

@goosewobbler goosewobbler commented Dec 11, 2023 •
edited
Loading

Fixes #313

christian-bromann
christian-bromann reviewed Dec 11, 2023
View reviewed changes
src/service.ts Show resolved Hide resolved
src/commands/execute.ts

export async function execute<ReturnValue, InnerArguments extends unknown[]>(
this: ElectronWorkerService,
browser: WebdriverIO.Browser,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then do:

Suggested change
browser: WebdriverIO.Browser,
this: WebdriverIO.Browser,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried these two - the instance test fails, producing an array of values again

@goosewobbler goosewobbler force-pushed the sm/mr-execute-fix branch 4 times, most recently from 8e6333f to ef8bc64 Compare December 12, 2023 12:27
@goosewobbler goosewobbler linked an issue Dec 12, 2023 that may be closed by this pull request
Flaky interaction E2Es #326
Closed
@goosewobbler goosewobbler removed a link to an issue Dec 12, 2023
Flaky interaction E2Es #326
Closed
@goosewobbler goosewobbler changed the title fix: pass browserInstance through to execute fix: pass browserInstance through to execute Dec 12, 2023
@goosewobbler goosewobbler merged commit 199a2ea into main Dec 12, 2023
4 checks passed
@goosewobbler goosewobbler deleted the sm/mr-execute-fix branch December 12, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiremote execute calls are returning an array of values for e.g. app.getName()
2 participants
@goosewobbler @christian-bromann