-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): jest/vitest like API mocking #255
Conversation
You may be able to fix the CI error by moving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests and types need to be improved, I'll make some changes in #269
This worked. |
Targetting a major release for this because the mocking interface has now changed completely. Removing the existing API access code will also improve unit coverage as some parts of it were not covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all great, nice work 👌
Let's update the mocking docs and emphasize the importance of using update
to get the latest mock data.
I am wondering if there is any way we can auto-update it, e.g. fetch mock updates in the afterCommand
hook to ensure that hooks are up to date after an interaction with the app. Anyway that should not block this PR to get merged. We could also think about calling update in our expect lib but that would couple these two packages which is not ideal.
Makes sense, created #311 for this work. I'll update the docs tomorrow which should enable a release. |
67b7877
to
c2808f1
Compare
@goosewobbler PR looks good, are we adding the two remaining todos to it? |
Yeah, just doing them now... |
Awesome work @goosewobbler 🎉 Thanks a lot! |
This implements suggestion 2 from #252
TODO: