(feat): detect app binary path for electron builder and forge #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
force-pushed
the
cb/detect-binary-path
branch
from
54143fd to
3a9b7a1
Compare
|
@goosewobbler I will go ahead and test this in the boilerplate. Let me know if you like to see anything changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would find the DX much better if the service could figure out the location of the Electron build based on some assumptions we can make given their setup. This patch allows users not to have to set the
appBinaryPathif they use Electron Builder or Electron Forge as build tool. The change is backwards compatible and only kicks in if the property isn't already set.Furthermore the launcher has tried to detect the Electron version by looking at the
electrondependency. However our example has usedelectron-nightlyso I enhanced that mechanism to also check for the version of that dependency.