Documentation: Add information regarding sandboxing, asar issues, improved code examples #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information about sandbox, asar issues and recommendations for environment variables to README
There was a problem hiding this comment.
Thank you very much for the PR @tomm1996 👍
I'll let Christian have a look as well since he originally wanted to pick this up
Co-authored-by: Christian Bromann <[email protected]>
Co-authored-by: Erwin Heitzman <[email protected]>
Co-authored-by: Erwin Heitzman <[email protected]>
christian-bromann
approved these changes
Oct 7, 2023
goosewobbler
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
Looks good, I tweaked the wording a bit. I wasn't aware of this sandbox issue, my testing has worked fine without specifying sandbox: false. I'll create another issue to update the example repos since it seems explicitly enabling sandboxing is recommended.
goosewobbler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information about sandbox, asar issues and recommendations for environment variables to README