-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver Service Fix #168
Driver Service Fix #168
Conversation
@christian-bromann So, @electron/get is the way we were downloading Chromedriver, I am not sure we can use it to get the CD version string in order to pass it to WDIO; |
I think there are two approaches we can go:
Wdyt? |
@christian-bromann I prototyped the first approach and it's not able to connect to Chromedriver when specifying the hostname / port. Is there anything obvious I could have missed? Output here. |
@goosewobbler the port |
Hmmm, that didn't work, it's now trying to connect to |
Can you check that you don't set any of these options in the service: |
It seems to be working and connecting properly now. |
@goosewobbler let me know if there is anything left to do to land this. Amazing work! |
@christian-bromann Thanks! With that latest PR I think it's done. Will run a couple of smoke tests with an external repo before release as there are a lot of changes here... |
Awesome, please feel free to merge and release as major change anytime you are ready. |
Awesome work 🎉 |
Updating the service for the breaking changes released with WDIO v8.14.0:
wdio-chromedriver-service
debug
TODO:
electron-to-chromium
for delegating CD download to WDIOwdio:chromedriverOptions
directly