Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples for Electron Forge #58

Closed
goosewobbler opened this issue Jan 31, 2023 · 2 comments
Closed

Update examples for Electron Forge #58

goosewobbler opened this issue Jan 31, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
6.x.y

Comments

@goosewobbler
Copy link
Member

goosewobbler commented Jan 31, 2023 •
edited
Loading

We should use Electron Forge for building the main two example apps (example & example-cjs).

Proposing a new example-electron-builder (ESM - duplicate of example) for testing an app built with EB.

https://www.electronforge.io/
https://www.electron.build/
@goosewobbler goosewobbler added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2023
@goosewobbler goosewobbler mentioned this issue Sep 29, 2023
Merged
15 tasks
@goosewobbler goosewobbler added this to the v5.1.0 milestone Oct 3, 2023
@goosewobbler goosewobbler changed the title Explicitly support electron-forge Explicitly support Electron Forge Oct 6, 2023
@goosewobbler goosewobbler changed the title Explicitly support Electron Forge Update examples for Electron Forge Oct 27, 2023
@goosewobbler goosewobbler removed this from the v5.2.0 milestone Oct 27, 2023
@goosewobbler
Copy link
Member Author

goosewobbler commented Oct 30, 2023 •
edited
Loading

This is halfway to complete, blocked on Forge ESM support - currently example-cjs is using Forge and example uses electron-builder. See #243 for more details.

@goosewobbler goosewobbler added this to the 6.1.0 milestone Nov 30, 2023
@goosewobbler
Copy link
Member Author

Implemented in 6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
6.x.y
Development

No branches or pull requests
1 participant
@goosewobbler