Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused which package #601

Conversation

alexparish
Copy link
Contributor

@alexparish alexparish commented Dec 11, 2024

Fixes #600

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do you know any neat CLI tool we can use as linter in our pipelines to detect these things?

@alexparish
Copy link
Contributor Author

👍

Do you know any neat CLI tool we can use as linter in our pipelines to detect these things?

Absolutely! I'd recommend knip: https://knip.dev/

@christian-bromann christian-bromann merged commit 414f91d into webdriverio-community:main Dec 11, 2024
5 checks passed
@christian-bromann
Copy link
Contributor

Absolutely! I'd recommend knip: knip.dev

Can you provide more information how this would look like? I would be keen introducing it to the toolchain if it doesn't require much configuration, e.g. extra configuration file.

@alexparish
Copy link
Contributor Author

Absolutely! I'd recommend knip: knip.dev

Can you provide more information how this would look like? I would be keen introducing it to the toolchain if it doesn't require much configuration, e.g. extra configuration file.

I’ve never set it up personally - I’ve just been running it locally. I do intend to have a go and I’ll get back to you if I have any luck.

@alexparish alexparish deleted the remove-unused-which-package branch December 11, 2024 21:04
@wdio-bot
Copy link
Contributor

Hey alexparish 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused which dependency
3 participants