feat: support spawnOpts for geckodriver child process #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
requested changes
Sep 26, 2024
AtofStryker
force-pushed
the
feat/add_spawn_option_to_gecko
branch
from
893750d to
ec9e561
Compare
christian-bromann
approved these changes
Sep 27, 2024
awesome I will get the docs updated then we should be good to go! |
|
docs updated @christian-bromann . Thank you for the really fast review on this! |
christian-bromann
merged commit 3edaf8e
into
webdriverio-community:main
5 checks passed
|
Hey AtofStryker 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently migrating Cypress to use
webdriverandgeckodriverfor our firefox automation. We have the needs to propagate some environment variables to the geckodriver process (better outlined in this bugzilla comment), which we are patching this package to accomplish now. This PR is to move this patch upstream as a contribution.In order to propagate environment variables to the firefox process started with
geckodriver, the environment variables need to be passed to thegeckodriverprocess directly in order to be passed tofirefox. This is important for settingMOZ_prefixed variables, likeMOZ_HEADLESS_HEIGHTorMOZ_HEADLESS_WIDTH. This PR allows spawn options to be passed into the geckodriver process.