Skip to content

Commit

Permalink
Update geckodriver (#99)
Browse files Browse the repository at this point in the history
  • Loading branch information
vladikoff authored Dec 21, 2021
1 parent 0583792 commit 3e25f3d
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 15 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Use `GECKODRIVER_SKIP_DOWNLOAD` to skip the download of the geckodriver file.
## Versions

* [npm module version] - [geckodriver version]
* 3.x.x - geckodriver 0.30.0, refactored logic, dependency updates.
* 2.00.x - geckodriver 0.29.1, support changed to node v12+
* 1.22.x - geckodriver 0.29.0
* 1.21.x - geckodriver 0.28.0
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function extract(archivePath) {
}
})
.then(function () {
console.log('Complete.');
process.stdout.write('Complete.');
})
.catch(function (err) {
console.log('Something is wrong ', err.stack);
Expand Down
2 changes: 1 addition & 1 deletion lib/geckodriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..');
exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver');

// specify the version of geckodriver
exports.version = process.env.GECKODRIVER_VERSION || '0.29.1';
exports.version = process.env.GECKODRIVER_VERSION || '0.30.0';

exports.start = function(args) {
exports.defaultInstance = require('child_process').execFile(exports.path, args);
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
},
"homepage": "https://github.com/vladikoff/node-geckodriver#readme",
"dependencies": {
"adm-zip": "0.5.5",
"adm-zip": "0.5.9",
"bluebird": "3.7.2",
"got": "11.8.2",
"tar": "6.1.9",
"tar": "6.1.11",
"https-proxy-agent": "5.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ test.cb('properly extracts', t => {
if (error) {
return t.fail(`exec error: ${error}`)
}
t.is(stdout, 'Downloading geckodriver... Extracting... Complete.\n');
t.assert(stdout.includes('Downloading geckodriver'), stdout);
t.is(stderr, '');
t.end();
});
});

test('programmatic usage', t => {
var driver = require('../lib/geckodriver')
t.is(driver.version, '0.29.1')
t.is(driver.version, '0.30.0')
});

0 comments on commit 3e25f3d

Please sign in to comment.