Post video #19
Merged
Post video #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hywook4
reviewed
Jan 22, 2021
| const maxTagCount = 5; | ||
| const maxTagLength = 10; |
There was a problem hiding this comment.
이건 수정 요청이나 이런거라기보단 나중에 어떻게 깔끔하게 같이 정리해서 하나의 파일로 정리하면 좋을 것 같습니다. ㅠㅜ 나중에 취합하도록 하죠
|
|
||
| const ok = await postVideo(id, title, description, tags); | ||
| if(!ok) { | ||
| alert("알 수 없는 에러가 발생하였습니다."); |
There was a problem hiding this comment.
API 에서 실패 원인을 내려주긴하는데 실패 원인을 보여줄 수 있으면 좋을 것 같습니다.
There was a problem hiding this comment.
현재 해당 API에서는 input validation을 통과하지 못하면 400 에러가 나는데, client-side에서도 validation을 체크한 상태여서 현재는 딱히 에러를 표시할게 없습니다.
이슈 등록해두고 추후에 에러코드가 다양해지면 수정하겠습니다.
|
|
||
| const AddVideo: React.FC = () => { | ||
| const { userInfo } = GetLogin(); | ||
| const { id, url, title, description, tags, init, setUrl, setTitle, setDescription, addTag, deleteTag } = AddVideoHook(); |
There was a problem hiding this comment.
여기서 addTag 한 이후에 다른페이지를 갔다가 다시 영상 추가 페이지로 이동할 시, tag들만 그대로 남아있는 문제가 있습니다. 영상 등록 성공 후에는 모든 제목, 영상 url, tag, 설명 등을 지워주는 로직을 추가하면 좋을 것 같습니다.
Open
|
LGTM입니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16
resolves #13 #9