FIX: present docker-compose.yml prevents share:restore when 'docker' … #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kitzberger When do you need such a call within a docker container? I don't get the real world scenario actually.
|
|
@josefglatz, that's almost one year ago, how should I remember ;-) but we probably had have a scenario like having all project files including the docker-compose.yml copied/mounted/cloned into the container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you wanna run
ct share:restore --mysqlfrom inside a docker container and there's a docker-compose.yml present that command quits with an exception because it fails to list all running docker containers. Because inside a docker container thedockerexecutable is usually not available.This patch makes sure the user is being asked in case
docker psfails whether or not they wanna continue.