Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udating svelte version to 4.2.2 #2274

Closed
wants to merge 2 commits into from

Conversation

OvidijusParsiunas
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OvidijusParsiunas
Copy link
Author

Svelte has recently published version 4.2.2 which fixes a camel case naming convention issue for properties. This PR version updates the Svelte version used within this repo to run the web component tests against it.

I am aware that there is another PR out there that updates some of Svelte tests, so if this PR overcomplicates things I am ok if it is declined.

@nileshtrivedi
Copy link

@rictic Could you please look at this PR to update the Svelte version and approve? If CLA is a problem, please consider approving #2296

@rictic
Copy link
Contributor

rictic commented Jul 12, 2024

Sorry for the delay, this needed to update the expectations too. Fixed in #2369

@rictic rictic closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants