Add a new QueryParams model

[hallvors]

This is just introducing a new QueryParams model. Nothing in this commit actually uses the new model yet, so if you want to test it you can only do so from the console:

var qp = new issueList.QueryParams();
qp.fromQueryString(location.search);
qp.setParam('label', 'firefox');
qp.setParam('stage', 'contactready');
qp.toBackendURL();

etc..

(BTW: you first have to add a SCRIPT element to the DOM that actually loads the new code..

document.body.appendChild(document.createElement('script')).src='/js/lib/models/query-params.js'

or something like that..)

[hallvors]

Trying to figure out those failures.. this is weird :( Adding [not ready] to title for now.

[hallvors]

Travis changed his mind when build was restarted. Weird stuff I saw locally was just a caching issue. OK to merge.

[miketaylr]

Tests are passing 👍, will review once I get through e-mail backlog.

[miketaylr]

I say let's pull this in once you address the comments -- I admit I don't have the full picture of how this works in my head yet. Which means you volunteer to fix most of the bugs for /issues until I do. :p

[miketaylr]

Once #860 lands, I suggest rebasing and re-running grunt to catch the eslint errors.

[miketaylr]

@hallvors want to fix the eslint errors then we can pull this in?

[hallvors]

eslint saved me some real debugging there 👍

Anyway, the "push" build still has this failure:

FAIL: main - Search (non-auth) - Search works (3588ms)
AssertionError: The search results show up on the page.: expected 'Issue 280: w3.org - desktop site instead of mobile site' to include 'vladvlad'

But I don't get why.. adding some code that's not even used anywhere yet shouldn't cause failures, right? What's the "push" build anyway?

[miketaylr]

What's the "push" build anyway?

Travis does two builds: push (when you push) and pr (if you make a pr). Your pr build passed, but the push one failed. I've seen that particular test fail in the past, so there's likely a bug somewhere. It seems to be somewhat random... so that's fun. 💣

[miketaylr]

Just retriggered the build (you can do that on Travis is you suspect weird results) and it's green now. Let's pull this one in.