Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cssfixme scripts, fixes #850 #853

Merged
merged 5 commits into from
Dec 15, 2015
Merged

Cssfixme scripts, fixes #850 #853

merged 5 commits into from
Dec 15, 2015

Conversation

hallvors
Copy link
Contributor

No description provided.

@hallvors
Copy link
Contributor Author

r?@miketaylr

do_fixup();
}

document.getElementById('fixedcss')[0].addEventListener('dblclick', function(e) {

This comment was marked as abuse.

This comment was marked as abuse.

@miketaylr
Copy link
Member

Can we add a section to CONTRIBUTING.md in the dev env setup about how to pull down the submodule?

I guess it doesn't need to be much more than: git submodule init && git submodule update

@hallvors
Copy link
Contributor Author

(At least some of these test failures were about stuff already fixed elsewhere, I did a rebase to latest master so we will see if that fixes things..

<label>
<input type="checkbox" name="compact">Compact output (whitespace only after closing brace)</label>
<pre id="fixedcss"></pre>
<script src="/js/cssfixme.min.js"></script>

This comment was marked as abuse.

This comment was marked as abuse.

@hallvors
Copy link
Contributor Author

I made a change to use the non-minified version of css-fixme.js but it's probably not quite consistent with the other stuff since this file is still built by combining three others during a build process. The reason for that is the fact two of those files comes from a Git submodule and thus live outside of the tree originally - they are copied into the tree by the build process. I'm not sure if we can do something to link this up without a build step..

@miketaylr
Copy link
Member

I made a change to use the non-minified version of css-fixme.js but it's probably not quite consistent with the other stuff since this file is still built by combining three others during a build process

I think that's a good compromise. Thanks.

miketaylr pushed a commit that referenced this pull request Dec 15, 2015
@miketaylr miketaylr merged commit b281546 into master Dec 15, 2015
@miketaylr miketaylr deleted the cssfixme-scripts branch December 15, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants