-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cssfixme scripts, fixes #850 #853
Conversation
do_fixup(); | ||
} | ||
|
||
document.getElementById('fixedcss')[0].addEventListener('dblclick', function(e) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Can we add a section to CONTRIBUTING.md in the dev env setup about how to pull down the submodule? I guess it doesn't need to be much more than: |
dc2894b
to
7b5c13e
Compare
(At least some of these test failures were about stuff already fixed elsewhere, I did a rebase to latest master so we will see if that fixes things.. |
<label> | ||
<input type="checkbox" name="compact">Compact output (whitespace only after closing brace)</label> | ||
<pre id="fixedcss"></pre> | ||
<script src="/js/cssfixme.min.js"></script> |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
I made a change to use the non-minified version of css-fixme.js but it's probably not quite consistent with the other stuff since this file is still built by combining three others during a build process. The reason for that is the fact two of those files comes from a Git submodule and thus live outside of the tree originally - they are copied into the tree by the build process. I'm not sure if we can do something to link this up without a build step.. |
I think that's a good compromise. Thanks. |
Add cssfixme scripts, fixes #850.
No description provided.