add incoming issues to local db, fixes #788

[hallvors]

r?@karlcow who seems to have read the code already

[hallvors]

Hm. I handled Karl's second comment before the first, and now GitHub shows my commit associated with wrong comment - oh well :)

[miketaylr]

I wasn't asked for review, but this looks good. Will defer to @karlcow.

[hallvors]

(Quite likely we should have some error handling if the content of a report doesn't fit those DB column sizes..)

[hallvors]

Two things to explore:

• Size limits for various fields
• If we should track deletion of issues, edits to issue description

[hallvors]

I wasn't asked for review

I'm just following the guidelines ;) - "don't ask more than one person for review"

[miketaylr]

@hallvors heh, no issues with what you've done or the process. I was just adding my 2 cents. 💰

[karlcow]

I think we should track deletion.
I would be happy to give r+ if we are not using the DB for now for production stuff. So write only and not read, for the purpose of testing on the rest of the code.

Does that sound reasonable?

[miketaylr]

I think we should track deletion.

I guess that's probably a new issue, to sync with GitHub API (deletion) changes.

So write only and not read, for the purpose of testing on the rest of the code

+1. Let's let it collect data for a few weeks and come back and inspect how it does. Also if we want deletion, we don't want to rely on anything until that's ready.

[miketaylr]

I would be happy to give r+ if we are not using the DB for now for production stuff. So write only and not read, for the purpose of testing on the rest of the code.

Does that sound reasonable?

@hallvors want to respond and then fix the merge conflicts? Assuming you agree with Karl I'll be happy to merge at that point.

[hallvors]

Rebased and fixed conflicts

[karlcow]

Let's see if we get interesting results.

[hallvors]

Wohoo!! :)