-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #660. Move all label namespace handling to models. #661
Conversation
Ah interesting. I would have thought of putting it on the python side more than the JS side. |
Hitting every nail with my JS 🔨
Yeah, we can do that. How long do you think until you can commit the first simple test? @ karlcow@5e2ae26 I can add some more tests specific to the changes in this PR after that. You mentioned there was a problem with Issue 100, can you explain that again? Maybe I should move the test repo to webcompat... |
You mean a Pull request? Because it is committed. :)
Let me reply in #648 |
Yes, a PR. |
Here it is sir. :) #662 |
Note for the future. I need to propose something where we handle this on the API side in the python code. More logical and less duplication of code. |
@karlcow is working on tests, so let's go ahead and pull this in so he's not working against a version of the tree that is going to change. |
Fixes #660. Move all label namespace handling to models.
I want to add some tests to this before we merge.
r? @karlcow