Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #660. Move all label namespace handling to models. #661

Merged
merged 7 commits into from
Aug 6, 2015

Conversation

miketaylr
Copy link
Member

I want to add some tests to this before we merge.

r? @karlcow

@karlcow
Copy link
Member

karlcow commented Aug 4, 2015

Ah interesting. I would have thought of putting it on the python side more than the JS side.
but cool! At least it's a working solution. ❤️
Tests are to be added in #272 ?

@miketaylr
Copy link
Member Author

Hitting every nail with my JS 🔨

Tests are to be added in #272 ?

Yeah, we can do that. How long do you think until you can commit the first simple test? @ karlcow@5e2ae26

I can add some more tests specific to the changes in this PR after that.

You mentioned there was a problem with Issue 100, can you explain that again? Maybe I should move the test repo to webcompat...

@karlcow
Copy link
Member

karlcow commented Aug 4, 2015

Yeah, we can do that. How long do you think until you can commit the first simple test? @ karlcow/webcompat.com@5e2ae26

You mean a Pull request? Because it is committed. :)

You mentioned there was a problem with Issue 100, can you explain that again? Maybe I should move the test repo to webcompat...

Let me reply in #648

@miketaylr
Copy link
Member Author

Yes, a PR.

@karlcow
Copy link
Member

karlcow commented Aug 5, 2015

Here it is sir. :) #662

@karlcow
Copy link
Member

karlcow commented Aug 5, 2015

Note for the future. I need to propose something where we handle this on the API side in the python code. More logical and less duplication of code.

@miketaylr
Copy link
Member Author

@karlcow is working on tests, so let's go ahead and pull this in so he's not working against a version of the tree that is going to change.

miketaylr pushed a commit that referenced this pull request Aug 6, 2015
Fixes #660. Move all label namespace handling to models.
@miketaylr miketaylr merged commit 4555010 into master Aug 6, 2015
@miketaylr miketaylr deleted the issues/660/1 branch August 6, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants