Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #511- make pagination buttons into links and update hrefs accordingly #553

Merged
merged 7 commits into from
Feb 13, 2015

Conversation

miketaylr
Copy link
Member

Mike Taylor added 5 commits February 5, 2015 17:07
(these aren't actually used by the client for pagination, but now you
can open a next page in a new tab or window, for example)
@magsout
Copy link
Member

magsout commented Feb 12, 2015

ooooops

@magsout
Copy link
Member

magsout commented Feb 12, 2015

some bug about history

->http://localhost:5000/
-> Click All issues
-> Click next
-> Click Site contacted

Sorry, no results were found.

You keep page init to 2 : http://localhost:5000/issues?page=2&per_page=50&state=open&stage=sitewait

I think if we click on any state, we have to reset page

@miketaylr
Copy link
Member Author

Ah. Yeah. That's a bug. ^_^

@miketaylr
Copy link
Member Author

It's a bug unrelated to this PR, but I'll make the fix in here and we can pull them both in at the same time. Thanks for catching that @magsout.

@miketaylr
Copy link
Member Author

OK, should be good to merge. 🎊

@magsout
Copy link
Member

magsout commented Feb 13, 2015

👍

magsout added a commit that referenced this pull request Feb 13, 2015
Fixes #511- make pagination buttons into links and update hrefs accordingly
@magsout magsout merged commit 757d6ae into master Feb 13, 2015
@magsout magsout deleted the issues/511/1 branch February 13, 2015 10:56
@miketaylr miketaylr restored the issues/511/1 branch July 20, 2015 19:04
@miketaylr miketaylr deleted the issues/511/1 branch July 21, 2015 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants