New color palette #521
Merged
New color palette #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be valuable to see this in staging so we can do a few review with the appropriate tools. :) |
|
okay ;) cc @miketaylr |
|
🍭 looks good @magsout ! You may want to add the colors in the comments like you did before like... /* Light green */ |
|
done @calexity |
|
Deployed to staging. Note that "needs contact" doesn't really exist yet, so you won't see any light green. |
|
Sorry, to clarify, is this pull request just the about page? If yes, looks all good. 0 color contrast errors on http://staging.webcompat.com/about :) |
|
@andrewmcgivery yeah it will affect the about page, as well as staging.webcompat.com/issues |
|
Looks like everyone is on board. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @andrewmcgivery
r? @calexity