Adds icons to navigation

[magsout]

I have updated the icons:

• Added .wc-Icon (naming conventions)
• Added icon to navigation (home - all issues - log out)

r? @calexity

[magsout]

Hum travis failed, let's try to git rebase and git push --force

[magsout]

@miketaylr maybe it's because I added another link on navigation ?

[miketaylr]

@magsout yeah, probably something similar. The test failures are all related to not logging in or logging out:

.findByCssSelector('.wc-Navbar-section--right .wc-Navbar-link').click()

So it wouldn't be hard to break that. Maybe if we add a .login-link class and update the tests they won't break as often. ^_^

[calexity]

Hooray for this! Can you make login say Log in ?

On Fri, Dec 19, 2014, 7:28 AM Mike Taylor [email protected] wrote:

@magsout https://github.com/magsout yeah, probably something similar.
The test failures are all related to not logging in or logging out:

.findByCssSelector('.wc-Navbar-section--right .wc-Navbar-link').click()

So it wouldn't be hard to break that. Maybe if we add a .login-link class
and update the tests they won't break as often. ^_^

—
Reply to this email directly or view it on GitHub
#499 (comment)
.

[magsout]

@calexity ok .

Hum question, with new link (all issues) there is enought space for small device

I wonder if display only the icon is enough?

[miketaylr]

We could give it a shot and see if people find it confusing.

[magsout]

@miketaylr @calexity

Maybe we need an icon for log in ?

[calexity]

@magsout You are right. I would use the same icon for Log in and Log out.

[miketaylr]

Yeah @magsout, would better if both login/logout had an icon.

[miketaylr]

Tests are passing, so let's pull this in.

[magsout]

Nice, thanks for your help @miketaylr