Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3016 - Remove current browser from list of tested browsers #3691

Merged
merged 1 commit into from
May 2, 2022

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Apr 28, 2022

Following the rule from this comment #3016 (comment)

@ksy36
Copy link
Contributor Author

ksy36 commented Apr 28, 2022

As an example, in Firefox:

Screen Shot 2022-04-28 at 4 52 44 PM

Chrome:
Screen Shot 2022-04-28 at 4 53 20 PM

When the current browser is not in the list OR when setting custom browser, all icons are displayed:

Screen Shot 2022-04-28 at 4 56 45 PM

@ksy36 ksy36 requested a review from karlcow April 28, 2022 20:59
@ksy36
Copy link
Contributor Author

ksy36 commented Apr 28, 2022

r? @karlcow

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.
Thanks @ksy36

@karlcow karlcow merged commit 2e03cfd into main May 2, 2022
@karlcow karlcow deleted the issue/3016/1 branch May 2, 2022 04:39
@ksy36
Copy link
Contributor Author

ksy36 commented May 2, 2022

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants