Fixes #3644 - Add a "moved" milestone #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksy36
commented
Nov 18, 2021
| @@ -43,6 +43,7 @@ export const Issue = Backbone.Model.extend({ | |||
| var milestoneClass; | |||
| if (response.milestone) { | |||
| milestone = response.milestone.title; | |||
| milestoneClass = response.milestone.title; | |||
| } else { | |||
There was a problem hiding this comment.
I've noticed that milestone labels were not coloured on the issue page, because a css class was missing, this is a fix for that.
currently:
will be:
ksy36
commented
Nov 18, 2021
| @@ -15,5 +15,5 @@ | |||
| <span class="label label-<%= data.milestoneClass %> js-Milestone"> | |||
| <%= data.milestone %> | |||
| </span> | |||
| </span> | |||
| </div> | |||
| </script> | |||
There was a problem hiding this comment.
There seems to be closing </span> instead of a </div>
|
r? @karlcow |
karlcow
requested changes
Nov 19, 2021
config/environment.py
Outdated
| @@ -100,7 +100,8 @@ | |||
| 'invalid': {'id': 0, 'order': 4, 'state': 'closed'}, | |||
| 'non-compat': {'id': 0, 'order': 5, 'state': 'closed'}, | |||
| 'wontfix': {'id': 0, 'order': 6, 'state': 'closed'}, | |||
| 'worksforme': {'id': 0, 'order': 7, 'state': 'closed'}} | |||
| 'worksforme': {'id': 0, 'order': 7, 'state': 'closed'}, | |||
| 'moved': {'id': 0, 'order': 1, 'state': 'closed'}} | |||
There was a problem hiding this comment.
Good to know, I'll change that :)
| @@ -43,6 +43,7 @@ export const Issue = Backbone.Model.extend({ | |||
| var milestoneClass; | |||
| if (response.milestone) { | |||
| milestone = response.milestone.title; | |||
| milestoneClass = response.milestone.title; | |||
| @@ -15,5 +15,5 @@ | |||
| <span class="label label-<%= data.milestoneClass %> js-Milestone"> | |||
| <%= data.milestone %> | |||
| </span> | |||
| </span> | |||
| </div> | |||
|
I've made the change, could you please take another look @karlcow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "moved" milestone for issues that were moved to other bug trackers or repositories (bugzilla, fenix, firefox-ios, etc.)