Fixes #3430 - Improve sliding animations on slow mobile phones #3484
Conversation
| @@ -10,380 +10,18 @@ <h1 class="headline-1">Report Site Issue</h1> | |||
| novalidate | |||
| > | |||
| <h3 class="page-heading">Filing a web compatibility issue</h3> | |||
There was a problem hiding this comment.
pretty much no changes here, just split this file into smaller html files
There was a problem hiding this comment.
yeah, makes it easier to digest.
| } | ||
| 100% { | ||
| margin-top: var(--presumed-high-step-height); | ||
| opacity: 0; |
There was a problem hiding this comment.
slidedown and slideup keyframes are replaced with js animations and instead of margin-top, translateY is being modified (that helped to speed things up)
|
r? @miketaylr |
| @@ -110,7 +110,7 @@ registerSuite("Reporting with wizard", { | |||
| // Click on "Desktop site instead of mobile site" | |||
| document.querySelector("[for=problem_category-0]").click(); | |||
| }) | |||
| .sleep(1000) | |||
| .sleep(1500) | |||
There was a problem hiding this comment.
increasing timeouts is always a code smell that a test should probably be re-written. however, i'm a fan of getting things to pass and kicking the timeout can down the road a bit. :)
There was a problem hiding this comment.
yeah, we could probably add a function to check whether animation and scrolling to a step is finished instead of using timeouts.. I'll file a bug for that
| complete: () => { | ||
| container.addClass("open"); | ||
| scrollToElement(domElement); | ||
| if (cb) cb(); |
There was a problem hiding this comment.
I am so disappointed that prettier allows this style. 😞
(lol, just a personal thing, no need for a change)
| @@ -10,380 +10,18 @@ <h1 class="headline-1">Report Site Issue</h1> | |||
| novalidate | |||
| > | |||
| <h3 class="page-heading">Filing a web compatibility issue</h3> | |||
There was a problem hiding this comment.
yeah, makes it easier to digest.
|
I've made the changes while testing on my phone on a local ip, so it should be good :) |
|
Thanks! |
In this PR I've changed the way steps are animated to make it perform faster on slow mobile phones