Fixes #3281 - Convert issue page to be server rendered (part 1) #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 22, 2020 17:12
(this makes it easier to use data coming from github as well)
This also makes sure we can handle client render updates when the milestone changes.
miketaylr
commented
Apr 22, 2020
miketaylr
commented
Apr 22, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miketaylr
commented
Apr 23, 2020
This comment has been minimized.
This comment has been minimized.
miketaylr
force-pushed
the
issues/3281/1
branch
from
b68b362 to
50a751a
Compare
|
TODO:
|
miketaylr
force-pushed
the
issues/3281/1
branch
2 times, most recently
from
6c0e0d6 to
2b00a2f
Compare
This comment has been minimized.
This comment has been minimized.
miketaylr
commented
Apr 24, 2020
This comment has been minimized.
This comment has been minimized.
miketaylr
force-pushed
the
issues/3281/1
branch
from
cae7700 to
f5c3efa
Compare
This comment has been minimized.
This comment has been minimized.
miketaylr
commented
Apr 28, 2020
miketaylr
commented
Apr 28, 2020
added 6 commits
April 28, 2020 16:57
Right now this requires us to have fixtures backing for any issues we test via unit tests. I'm not sure if that's good or bad yet.
And add some tests
Unused since ad80ecc
karlcow
requested changes
Apr 29, 2020
There was a problem hiding this comment.
a couple of comments. :) hope it helps.
Super encouraging, super cool to work on that. thanks @miketaylr
ksy36
approved these changes
Apr 29, 2020
The server handles the initial render, but the client needs to react accordingly when things get changed.
We just bootstrap the issue model by dumping the data we already have to JSON. (In retrospect, we could have done this at the beginning and called it a day...)
binary response content we return from api calls. https://requests.readthedocs.io/en/master/user/quickstart/#binary-response-content
The nonce was random for each request, so it broke etags / caching.
Co-Authored-By: Karl Dubost <[email protected]>
miketaylr
force-pushed
the
issues/3281/1
branch
from
7569dcd to
2d8b30a
Compare
|
Heh, managed to mess things up while rebase. |
|
OK, apologies for the messy merge commit. r? @karlcow |
karlcow
requested changes
Apr 29, 2020
Co-Authored-By: Karl Dubost <[email protected]>
|
some edits, one rebase, let's run the tests. |
|
And this is merged. |
|
❤️ |
|
Super nice work 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I'm going to leave this as a draft. I decided to not tackle existing comments here just to keep things small. I'll file a follow-up on that and tackle it once this lands.