Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier to the latest version 🚀 #3274

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Apr 5, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The devDependency prettier was updated from 1.19.0 to 2.0.3.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: thorn0
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@magsout
Copy link
Member

magsout commented Apr 6, 2020

I will update locally to see the difference

greenkeeper bot added a commit that referenced this pull request Apr 6, 2020
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Apr 6, 2020

  • The devDependency prettier was updated from 1.19.0 to 2.0.4.

Update to this version instead 🚀

Release Notes for 2.0.4

🔗 Changelog

@magsout
Copy link
Member

magsout commented Apr 6, 2020

@miketaylr @ksy36 I just ran the command npm run lint:fix:js.

you can see the Breaking changes here https://prettier.io/blog/2020/03/21/2.0.0.html main changes are about the default values of railingComma, arrowParens, and endOfLine.

what do you think about these changes? If you don't like we can change the configuration

@miketaylr
Copy link
Member

LGTM -- I personally don't care about any prettier output, as long as it's consistent. :)

@miketaylr
Copy link
Member

(One tiny nit: can we update your commit message to refer to this PR? Issue #3274 - bumped Prettier or something?)

@magsout magsout force-pushed the greenkeeper/prettier-2.0.3 branch from 4654f00 to 18c02cc Compare April 7, 2020 07:24
Copy link
Contributor

@ksy36 ksy36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magsout :)

@ksy36 ksy36 merged commit 0d260f5 into master Apr 7, 2020
@greenkeeper greenkeeper bot deleted the greenkeeper/prettier-2.0.3 branch April 7, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants