Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3196 - Add functional tests for the new form UI #3221

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fixes #3196 - Add functional tests for the new form UI #3221

merged 1 commit into from
Feb 28, 2020

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Feb 26, 2020

miketaylr
miketaylr reviewed Feb 26, 2020
View reviewed changes
webcompat/templates/issue-wizard-form.html
@@ -371,6 +371,7 @@ <h3 class="page-heading">Filing a web compatibility issue</h3>
name="github-proxy-report">
Send report
</button>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

miketaylr
miketaylr approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks. I'm sure there's other things we can cover, but a massive improvement.

Could you add some comments about the scenarios before merging?

tests/functional/reporting-issue-wizard-non-auth.js Show resolved Hide resolved
@ksy36
Copy link
Contributor Author

ksy36 commented Feb 27, 2020

Good point, thanks :)

@ksy36
Copy link
Contributor Author

ksy36 commented Feb 28, 2020

Got 6 continuous jobs successfully passing, so I think it's good to go. @miketaylr could you please take a look one more time?

@miketaylr
Copy link
Member

Thanks!

@miketaylr miketaylr merged commit f3bed72 into master Feb 28, 2020
@miketaylr miketaylr deleted the issue/3196/1 branch February 28, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksy36 @miketaylr