Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2945 - Update Intern to 4.7.0 #3105

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fixes #2945 - Update Intern to 4.7.0 #3105

merged 1 commit into from
Dec 5, 2019

Conversation

miketaylr
Copy link
Member

No description provided.

@miketaylr
Copy link
Member Author

(ノಠ益ಠ)ノ彡┻━┻
SessionNotCreatedException: [POST http://localhost:4444/wd/hub/session / {"desiredCapabilities":{"moz:firefoxOptions":{"args":["-headless"],"prefs":{"security.csp.enable":false},"binary":"/usr/local/bin/firefox"},"name":"intern","idle-timeout":60,"browserName":"chrome","chromeOptions":{"args":["headless","disable-gpu"]}}}] session not created: This version of ChromeDriver only supports Chrome version 78
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
System info: host: '2d063679da95', ip: '172.22.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-1052-aws', java.version: '11.0.3'
Driver info: driver.version: unknown
remote stacktrace: #0 0x55b29b9497e9 <unknown>

  at Suite.before @ src/lib/executors/Node.ts:483:15
  @ src/lib/Suite.ts:433:54
  at runLifecycleMethod @ src/lib/Suite.ts:398:13
  at before @ src/lib/Suite.ts:501:13
  at Suite.run @ src/lib/Suite.ts:520:10
  @ src/lib/executors/Node.ts:933:27
  at FunctionQueue.next @ src/lib/executors/Node.ts:1061:19

TOTAL: tested 1 platforms, 95 passed, 0 failed; fatal error occurred

Cool.

@miketaylr
Copy link
Member Author

Kind of annoying, I guess we can just pin it to a reasonably new version of Chrome/Chromedriver.... and maybe update it in the future.

@miketaylr
Copy link
Member Author

I should have made this a draft PR...

@miketaylr
Copy link
Member Author

Also updated Chromedriver version here. Eventually we'll probably have to solve this -- in Chromedriver 70, they changed versions to match Chrome stable releases. Chrome doesn't have stable download URLs for arbitrary versions, AFAICT. So there's a possible future where Chrome tests start breaking (because they broke backwards compat w/ 2.44 or whatever) and we have to figure out how to tell Intern to load whatever chromedriver version gets installed on circleci.

Let's just kick that can down the road. 🤷‍♂ 🤷‍♀

@miketaylr
Copy link
Member Author

r=me, just updating deps and tests still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant