Fixes #2940 - Add a label to v2 form issues #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2019 19:25
#2954 will be the issue to track to know when we can remove this.
karlcow
approved these changes
Oct 9, 2019
| @@ -263,6 +263,8 @@ def create_issue(): | |||
|
|
|||
| if ab_active('exp') == 'form-v2': | |||
| bug_form = get_form(form_data, form=FormWizard) | |||
| # TODO: remove this when the experiment has ended | |||
| form_data['extra_labels'].append('form-v2-experiment') | |||
There was a problem hiding this comment.
I guess in one way or the other this full code will disappear anyway be in the case of rejecting or adopting the new form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard-coded, but shortlived. We can also use
labelparam if we want to, but this way seems easiest.r? @karlcow
webcompat/webcompat-tests#1953 is a sample issue (filed from chrome!!111), which has the label added, as well as the
<!-- @extra_labels: form-v2-experiment -->comment.