Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2793 - Comments are sent as markdown to Github #2800

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

marimeireles
Copy link
Member

@marimeireles marimeireles commented Feb 13, 2019

Locally they're rendered correctly in the website in the moment that they're posted:
screen shot 2019-02-13 at 16 35 17

Checking the code that is sent to Github:
screen shot 2019-02-13 at 16 35 04
it's markdown!

r? @karlcow

@marimeireles marimeireles changed the title Fixes #2793 - Comments are send as markdown to Github Fixes #2793 - Comments are sent as markdown to Github Feb 13, 2019
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about separating posting and showing.

webcompat/static/js/lib/issues.js Show resolved Hide resolved
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deploy this. Thanks a lot @marimeireles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants