Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2757 - Add markdown-it to issues on production #2758

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

marimeireles
Copy link
Member

@marimeireles marimeireles commented Jan 10, 2019

Mike found the answer! :)

r? @karlcow

@marimeireles
Copy link
Member Author

marimeireles commented Jan 10, 2019

Do I need to clean my commit history by rebasing?
I forgot to update the branch before creating the PR :/

@miketaylr
Copy link
Member

Do I need to clean my commit history by rebasing?

If you can, that would be nice (before we merge). :))

@miketaylr miketaylr self-requested a review January 10, 2019 18:58
@miketaylr
Copy link
Member

r? @karlcow

(going to steal this review)

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to rebase, then we'll merge.

grunt-tasks/concat.js Show resolved Hide resolved
@karlcow
Copy link
Member

karlcow commented Jan 11, 2019

❤️ to the two of you! Thanks @marimeireles and @miketaylr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants