Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2663 - Reduce number of untriaged bugs on homepage #2664

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Fixes #2663 - Reduce number of untriaged bugs on homepage #2664

merged 1 commit into from
Oct 19, 2018

Conversation

Anushi1998
Copy link
Contributor

Fixes #2663 - Reduce number of untriaged bugs displayed on homepage and renamed diagnose to untriaged.

Let me know if I missed something :)

r? @miketaylr

@miketaylr
Copy link
Member

Ah yeah, whoops. We need to update the test assertions:

127.0.0.1 - - [19/Oct/2018 01:53:49] "GET /api/issues/category/needstriage HTTP/1.1" 200 -
× chrome 70.0.3538.67 on Linux - Index - browse issues (needstriage) (0.144s)
    AssertionError: 10 issues should be displayed: expected 5 to equal 10
      at Command.<anonymous>  <tests/functional/index-non-auth.js:64:18>
      at Test.browse issues (needstriage) [as test]  <tests/functional/index-non-auth.js:63:10>
      at <src/lib/Test.ts:263:51>

miketaylr
miketaylr requested changes Oct 19, 2018
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you just update the test? Thanks!

@Anushi1998
Fixes webcompat#2663 - Reduce number of untriaged bugs on homepage an…
467c291 
…d renamed usage of diagnose.js

Updated tests to be compatible with 5 `needstriage` issues in homepage

Signed-off-by: Anushi Maheshwari <[email protected]>
@Anushi1998
Copy link
Contributor Author

@miketaylr I have updated tests, and looks CI is happy now :)

miketaylr
miketaylr approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉 🎈

@miketaylr miketaylr merged commit f0d7008 into webcompat:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anushi1998 @miketaylr @karlcow