Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2580 - Adds the missing webhooks route to the app #2581

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fixes #2580 - Adds the missing webhooks route to the app #2581

merged 1 commit into from
Sep 17, 2018

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Sep 17, 2018

This PR fixes issue #2580

Proposed PR background

  • This adds the (missing) webhooks route on the project.
  • It also adds a test to avoid this happens again.

@miketaylr r?

@karlcow karlcow requested a review from miketaylr September 17, 2018 01:13
@karlcow karlcow mentioned this pull request Sep 17, 2018
Closed
@TravisBuddy
Copy link

Hey @karlcow,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@karlcow
Copy link
Member Author

karlcow commented Sep 17, 2018

fixed the @TravisBuddy complaint. :)

miketaylr
miketaylr approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@miketaylr miketaylr merged commit 38acfe9 into webcompat:master Sep 17, 2018
@karlcow karlcow deleted the 2580/1 branch October 17, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlcow @TravisBuddy @miketaylr