-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2501 - Make temporary logfile location platform independent. #2502
Conversation
This uses /webcompat.com/tmp/, which is a location that is already gitignore'd.
Travis tests have failedHey @miketaylr, 1st Buildnpm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Thanks @miketaylr to have made it easier for Windows developers. And to make it more accessible for everyone.
I have one concern only. The log is prone to destruction if we reinstall the project from zero. Maybe not an issue. :)
r+
tempfile.tempdir = os.path.join(os.getcwd(), 'tmp') | ||
print('Writing logs to: {}'.format(tempfile.gettempdir())) | ||
|
||
LOG_FILE = os.path.join(tempfile.gettempdir(), 'webcompat.log') |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
```bash | ||
> python run.py | ||
Statuses Initialization… | ||
Writing logs to: /Users/acooluser/projects/webcompat.com/tmp |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
test failing with travis, but I suspect this is the project initialization. |
Oh crud... next time that happens, please don't restart -- I want to see if any of our extra logging turned anything up. :) edit: nice, it failed again:
|
r? @karlcow