Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2465 - Upgrades Flask to 1.0.2 #2485

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jun 6, 2018

This PR fixes issue #2465

Proposed PR background

This upgrades to the first stable release of Flask.
It is a step that will help us improve logging and the switch to python3
Functional tests and unit tests are passing.

r? @miketaylr

@karlcow karlcow requested a review from miketaylr June 6, 2018 22:20
@TravisBuddy
Copy link

Travis tests have failed

Hey @karlcow,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

nosetests
Milestones are not initialized. Check logs.
npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`
> webcompat@ test:js /home/travis/build/webcompat/webcompat.com
> node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"

Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
  at ClientRequest.<anonymous>  <tests/functional/lib/setup.js:55:9>
  at emitOne  <events.js:116:13>
  at ClientRequest.emit  <events.js:211:7>
  at Socket.socketErrorListener  <_http_client.js:387:9>
  at emitOne  <events.js:116:13>
  at Socket.emit  <events.js:211:7>
  at emitErrorNT  <internal/streams/destroy.js:64:8>
{ Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
    at ClientRequest.<anonymous> (/home/travis/build/webcompat/webcompat.com/tests/functional/lib/setup.js:55:9)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at Socket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) reported: true }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat@ test:js: `node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat@ test:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-06-06T22_23_05_313Z-debug.log

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2018

huh travis what did you find? 😄

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2018

→ python run.py -t
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
Starting server in ~*TEST MODE*~
 * Serving Flask app "webcompat" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: on
 * Running on http://localhost:5000/ (Press CTRL+C to quit)
 * Restarting with stat
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
Starting server in ~*TEST MODE*~
 * Debugger is active!
 * Debugger PIN: 195-432-804

Working for me locally.

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2018

And this is working too.

capture d ecran 2018-06-07 a 07 33 12

Let's kick again travis.

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2018

That's better. Next will be #2463 once this one is merged.

@miketaylr
Copy link
Member

huh travis what did you find? 😄

Yeah, seems like Travis just fails to start tests half the time... annoying. #2375

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking thru http://flask.pocoo.org/docs/1.0/upgrading/, I don't see anything to worry about here.

Thanks!

@miketaylr miketaylr merged commit 35deee4 into webcompat:master Jun 7, 2018
@karlcow karlcow deleted the 2465/2 branch October 17, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants