Fixes #1794. Prevent form submission when pressing enter #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
commented
Jan 5, 2018
webcompat/static/js/lib/bugform.js
Outdated
| // prevent accidental submission with the Enter key | ||
| // (for now, just the description input) | ||
| Mousetrap.bind("enter", function(e) { | ||
| if (e.target.className.indexOf('js-desc') !== -1) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
miketaylr
force-pushed
the
issues/1794/1
branch
from
9f874f3
to
8b6ca99
Compare
miketaylr
changed the title
|
ping @zoepage |
zoepage
suggested changes
Jan 10, 2018
| @@ -56,7 +56,7 @@ <h3 class="wc-Title--s">Report Site Issue</h3> | |||
| {% endif %} | |||
| </div> | |||
| <span class="wc-Form-validation"> | |||
| {{ form.description(class_='wc-Form-item required', | |||
| {{ form.description(class_='wc-Form-item required mousetrap js-desc', | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
miketaylr
force-pushed
the
issues/1794/1
branch
from
8b6ca99
to
c15619f
Compare
|
This maybe broke other tests... I didn't bother to check Travis because things were broken when I wrote this. >_< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in the description input.
r? @zoepage