Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1995 - Adds proper unicode handling for Form data #1998

Merged
merged 4 commits into from
Jan 4, 2018
Merged

Fix #1995 - Adds proper unicode handling for Form data #1998

merged 4 commits into from
Jan 4, 2018

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jan 4, 2018

This fixes the issue that @softvision-oana-arbuzov found and a couple of others related to unicode in the form (that were not seen before because of breaking in cascade).

→ nosetests -v --nocapture tests/test_form.py
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
The data body sent to GitHub API. ... ok
Check that domain name is extracted. ... ok
Checks we return the right form with the appropriate data. ... ok
HTML comments need the right values depending on the keys. ... ok
Check that metadata is processed and wrapped. ... ok
Avoid some type of strings. ... ok
Check that URL is normalized. ... ok
Check that appropriate radio button label is returned. ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.007s

OK

form tests are passing. Added a couple of tests.

And the general unittests are still passing.

→ nosetests --nocapture
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
........................................................................
----------------------------------------------------------------------
Ran 72 tests in 2.060s

OK

@karlcow
Issue webcompat#1995 - Adds test for form with unicode strings
83e2dd6 
Make sure the URL is treated as a unicode string and that it doesn’t
break down the pipe when manipulating it.
@karlcow
Issue webcompat#1995 - Adds tests for Unicode URLs
32a95fd 
Fixing this because it is a secondary break uncovered in the 1995 issue.
@karlcow
Issue webcompat#1995 - Adds proper unicode handling to the form
0cb2b23
@karlcow
Issue webcompat#1995 - Adds proper unicode handling to url normalisation
0256790
@karlcow
Copy link
Member Author

karlcow commented Jan 4, 2018

r? @miketaylr
r? @zoepage

@karlcow karlcow mentioned this pull request Jan 4, 2018
Merged
miketaylr
miketaylr approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks karl

@miketaylr miketaylr merged commit 619926a into webcompat:master Jan 4, 2018
@karlcow karlcow deleted the 1995/1 branch March 30, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

@zoepage zoepage Awaiting requested review from zoepage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlcow @miketaylr