Fixes #1986 - Start migration to Intern 4 #1987
Conversation
|
Great work Bea! :) s/guys/folks |
|
We can add Chrome back as a default once this lands, since it will put us on a modern digdug that supports pointing to the latest Chromedriver (the 2nd part of the issue that broke tests (the first being the travis trusty image update)). |
|
@miketaylr Yes, I think so. From the tests that I have already migrated, none of them have had any issues with Chorme, and surprise surprise, they don't even have many issues with Safari, we might be able to add both browsers by default, maybe. |
|
one happy sight. What still needs to be done:
|
aww wyeah. :) |
tests/intern.js
Outdated
| }); | ||
|
|
||
| intern.run(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
- Adds 'browsers' optional argument when running tests - Changes folder structure separating functional and unit tests completely - Also fixes webcompat#1977 and webcompat#1981.
brizental
force-pushed
the
issues/1986/1
branch
from
0e6c0da to
30cd7fb
Compare
Oh yeah! |
|
Forgot to mention: I will look at Safari issues after this is done. Even though we have much less errors, we are still getting a bunch of intermittents. Thought it would be best to send this in and finish this PR with Chrome and Firefox only for now :) |
brizental
changed the title
Awesome agreed. Let me file an issue so we have a paper trail. |
(bea pointed out that an issue already exists: #1704) |
| @@ -0,0 +1,68 @@ | |||
| /* This Source Code Form is subject to the terms of the Mozilla Public | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm, i see you addressed @vladikoff's feedback.
thanks a lot @brizental. 💯 🍰
|
Now I guess I should read the Intern 4 changelog to see what cool new stuff we can do. :) |
|
@brizental was there a reason to change the folder structure for unit tests? |
|
@karlcow I thought that, since I was putting everything about the functional tests inside a |
Just a test so you guys can see how everything will look like. I will continue the migration from this branch.