Fixes #1973 - Adds normalization of metadata values. #1974

karlcow · 2017-12-07T06:41:21Z

Following discussions in #1971, the goal of this pull request is to sanitize a bit. This is not perfect but should remove some of the issue. It goes on the side of safe play. For example if it detects there is > or < it just sends back an empty string instead of trying to clean up.

webcompat/form.py

@@ -154,6 +159,22 @@ def normalize_url(url):
    return url


+def normalize_metadata(metadata_value):
+    """Normalize the metadata received from the form."""
+    # Removing closing comments.


karlcow · 2017-12-07T14:24:41Z

→ nosetests --nocapture -v tests/test_form.py
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
The data body sent to GitHub API. ... ok
Check that domain name is extracted. ... ok
Checks we return the right form with the appropriate data. ... ok
HTML comments need the right values depending on the keys. ... ok
Check that metadata is processed and wrapped. ... ok
Avoid some type of strings. ... ok
Check that URL is normalized. ... ok
Check that appropriate radio button label is returned. ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.007s

OK

and the full test suite is still running.

nosetests
........................................................................
----------------------------------------------------------------------
Ran 72 tests in 2.468s

OK

I didn't run the functional tests though. Maybe to double check before.

miketaylr

Looks good, just one question about normalize_metadata

tests/test_form.py

+                 ('blue sky ', 'blue sky'),
+                 ('bad_bird <script>', ''),
+                 ('bad_bird <script-->>', ''),
+                 ('a' * 300, ''),


webcompat/form.py

+        return None
+    if '-->' in metadata_value:
+        metadata_value = metadata_value.replace('-->', '')
+        metadata_value = normalize_metadata(metadata_value)


webcompat/form.py

+        metadata_value = metadata_value.replace('-->', '')
+        metadata_value = normalize_metadata(metadata_value)
+    # Let's avoid html tags in
+    if ('<' or '>') in metadata_value and '-->' not in metadata_value:


webcompat/form.py

+    # Let's avoid html tags in
+    if ('<' or '>') in metadata_value and '-->' not in metadata_value:
+            metadata_value = ''
+    if len(metadata_value) > 200:


miketaylr · 2017-12-08T16:03:53Z

Looks good, thanks @karlcow.

karlcow added 3 commits December 7, 2017 13:37

Issue webcompat#1973 - fixes syntax and style.

9a52ea0

Issue webcompat#1973 - Adds tests for normalised values

77dea50

Issue webcompat#1973 - Adds normalisation of metadata in form

7727d02

karlcow added the in progress label Dec 7, 2017

karlcow requested review from miketaylr and zoepage December 7, 2017 06:41

karlcow mentioned this pull request Dec 7, 2017

Investigate "browser-firefox-mobile-nightly-59.0a1" label on issue #1971

Closed

zoepage reviewed Dec 7, 2017

View reviewed changes

miketaylr reviewed Dec 7, 2017

View reviewed changes

miketaylr merged commit 58d7215 into webcompat:master Dec 8, 2017

miketaylr added the status: add to changelog label Dec 8, 2017

miketaylr removed the status: add to changelog label Jan 12, 2018

karlcow deleted the 1973/1 branch March 30, 2018 05:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1973 - Adds normalization of metadata values. #1974

Fixes #1973 - Adds normalization of metadata values. #1974

karlcow commented Dec 7, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Dec 7, 2017

miketaylr left a comment •

edited

Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Dec 8, 2017

Fixes #1973 - Adds normalization of metadata values. #1974

Fixes #1973 - Adds normalization of metadata values. #1974

Conversation

karlcow commented Dec 7, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Dec 7, 2017

miketaylr left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Dec 8, 2017

miketaylr left a comment •

edited

Loading