Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1857. Add a NeedsTriage Issues Dashboard #1947

Merged
merged 14 commits into from
Nov 30, 2017
Merged

Fixes #1857. Add a NeedsTriage Issues Dashboard #1947

merged 14 commits into from
Nov 30, 2017

Conversation

miketaylr
Copy link
Member

All commits have already been reviewed, this exists to merge into master. I'll give it a review as well (since I didn't do any of the work :p)

Nice work @magsout @karlcow.

@miketaylr
Copy link
Member Author

ok, rebased against master and fixed the merge conflict. ready for re-review.

karlcow and others added 13 commits November 30, 2017 16:23
* helpers now contains a specific function for milestones.
  We grab the data by using the API function.
* the endpoints route for issues/category accepts now a parameter.
  This allows us to query 100 issues per default.
  It doesn't affect the normal route.
- Adds a more generic function to compute the threshold for time.
- Makes the fixture in the past so we don't run in an uncanny situation.
- Modifies the patch so it mocks the return value for the control date.
* Issue #1861 - Improvements and filtering for dashboard design
@miketaylr
Copy link
Member Author

Interesting error when I try to run the app on the branch:

🐓 python run.py 
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
Traceback (most recent call last):
  File "run.py", line 35, in <module>
    from webcompat import app
  File "/Users/mitaylor/dev/webcompat.com/webcompat/__init__.py", line 30, in <module>
    import webcompat.views  # nopep8
  File "/Users/mitaylor/dev/webcompat.com/webcompat/views.py", line 355, in <module>
    @app.route('/dashboard/triage')
  File "/Users/mitaylor/.virtualenvs/webcompat/lib/python2.7/site-packages/flask/app.py", line 1080, in decorator
    self.add_url_rule(rule, endpoint, f, **options)
  File "/Users/mitaylor/.virtualenvs/webcompat/lib/python2.7/site-packages/flask/app.py", line 64, in wrapper_func
    return f(self, *args, **kwargs)
  File "/Users/mitaylor/.virtualenvs/webcompat/lib/python2.7/site-packages/flask/app.py", line 1051, in add_url_rule
    'existing endpoint function: %s' % endpoint)
AssertionError: View function mapping is overwriting an existing endpoint function: dashboard_triage

@miketaylr
Copy link
Member Author

screen shot 2017-11-30 at 4 26 55 pm

That would explain it.

@miketaylr
Copy link
Member Author

Even with the history oddness, r+.

(I don't want to screw up other people's commits -- too scary 👻)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants