-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1857. Add a NeedsTriage Issues Dashboard #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok, rebased against master and fixed the merge conflict. ready for re-review. |
* helpers now contains a specific function for milestones. We grab the data by using the API function. * the endpoints route for issues/category accepts now a parameter. This allows us to query 100 issues per default. It doesn't affect the normal route.
- Adds a more generic function to compute the threshold for time. - Makes the fixture in the past so we don't run in an uncanny situation. - Modifies the patch so it mocks the return value for the control date.
Interesting error when I try to run the app on the branch:
|
Even with the history oddness, r+. (I don't want to screw up other people's commits -- too scary 👻) |
miketaylr
added
status: add to changelog
and removed
in progress
status: add to changelog
labels
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commits have already been reviewed, this exists to merge into master. I'll give it a review as well (since I didn't do any of the work :p)
Nice work @magsout @karlcow.