Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1620 - Gets all functional tests to work offline. #1625

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

brizental
Copy link
Contributor

@miketaylr
Copy link
Member

I get some test failures: https://gist.github.com/miketaylr/4becab632120c9bf83463f2eabf1272d

Do they all pass on your machine?

@miketaylr
Copy link
Member

yes

@miketaylr
Copy link
Member

oops, forgot to run in test mode. >_<

@miketaylr
Copy link
Member

@brizental can you check out these failures, por favor?

FAIL: firefox on any platform - Issue-list - Pressing g goes to github issues (1ms)
TypeError: (intermediate value).end is not a function
  at Test.Pressing g goes to github issues [as test]  <tests/functional/issue-list-non-auth.js:207:15>
FAIL: firefox on any platform - Search (auth) - Search works by Return key (10289ms)
NoSuchElement: An element could not be located on the page using the given search parameters.
  at Test.Search works by Return key [as test]  <tests/functional/search-auth.js:135:12>

@brizental
Copy link
Contributor Author

The first test was actually a typo, I fixed it. The second test is really failing but it's not related to this issue, probably something like #1470 I'll look into it at some point.

@miketaylr
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants